CVE-2023-34450
published 2023-07-03CVE-2023-34450: CometBFT is a Byzantine Fault Tolerant (BFT) middleware that takes a state transition machine and replicates it on many machines. An internal modification made…
PriorityP426medium5.3CVSS 3.1
AVNACLPRNUINSUCNINAL
EPSS
0.69%
48.1th percentile
CometBFT is a Byzantine Fault Tolerant (BFT) middleware that takes a state transition machine and replicates it on many machines. An internal modification made in versions 0.34.28 and 0.37.1 to the way struct `PeerState` is serialized to JSON introduced a deadlock when new function MarshallJSON is called. This function can be called from two places. The first is via logs, setting the `consensus` logging module to "debug" level (should not happen in production), and setting the log output format to JSON. The second is via RPC `dump_consensus_state`.
Case 1, which should not be hit in production, will eventually hit the deadlock in most goroutines, effectively halting the node.
In case 2, only the data structures related to the first peer will be deadlocked, together with the thread(s) dealing with the RPC request(s). This means that only one of the channels of communication to the node's peers will be blocked. Eventually the peer will timeout and excluded from the list (typically after 2 minutes). The goroutines involved in the deadlock will not be garbage collected, but they will not interfere with the system after the peer is excluded.
The theoretical worst case for case 2, is a network with only two validator nodes. In this case, each of the nodes only has one `PeerState` struct. If `dump_consensus_state` is called in either node (or both), the chain will halt until the peer connections time out, after which the nodes will reconnect (with different `PeerState` structs) and the chain will progress again. Then, the same process can be repeated.
As the number of nodes in a network increases, and thus, the number of peer struct each node maintains, the possibility of reproducing the perturbation visible with two nodes decreases. Only the first `PeerState` struct will deadlock, and not the others (RPC `dump_consensus_state` accesses them in a for loop, so the deadlock at the first iteration causes the rest of the iterations of that "for" loop to never be reached).
Affected
6 ranges
| Vendor | Product | Version range | Fixed in |
|---|---|---|---|
| cometbft | cometbft | — | — |
| cometbft | cometbft | — | — |
| cometbft | cometbft | >= 0.34.28 < 0.34.29 | 0.34.29 |
| cometbft | cometbft | >= 0.37.1 < 0.37.2 | 0.37.2 |
| github.com | cometbft_cometbft | >= 0.34.28 < 0.34.29 | 0.34.29 |
| github.com | cometbft_cometbft | >= 0.37.1 < 0.37.2 | 0.37.2 |
Stop checking back — get the weekly exploitation signal.
Every Monday: what got weaponized or added to CISA KEV in the last seven days — each CVE cross-linked to its PoC, Nuclei template, and detection rule. Free, one email a week, unsubscribe in one click.
OSV
Deadlock in github.com/cometbft/cometbft/consensus
osv·2023-07-06
CVE-2023-34450 Deadlock in github.com/cometbft/cometbft/consensus
Deadlock in github.com/cometbft/cometbft/consensus
An internal modification to the way PeerState is serialized to JSON introduced a deadlock when the new function MarshalJSON is called.
This function can be called in two ways. The first is via logs, by setting the consensus logging module to "debug" level (which should not happen in production), and setting the log output format to JSON. The second is via RPC dump_consensus_state.
GHSA
CometBFT PeerState JSON serialization deadlock
ghsa·2023-07-05
CVE-2023-34450 [MEDIUM] CWE-401 CometBFT PeerState JSON serialization deadlock
CometBFT PeerState JSON serialization deadlock
### Impact
An internal modification to the way struct `PeerState` is serialized to JSON introduced a deadlock when new function MarshallJSON is called. This function can be called from two places:
1. Via logs
* Setting the `consensus` logging module to "debug" level (should not happen in production), and
* Setting the log output format to JSON
2. Via RPC `dump_consensus_state`
Case 1 above, which should not be hit in production, will eventually hit the deadlock in most goroutines, effectively halting the node.
In case 2, only the data structures related to the first peer will be deadlocked, together with the thread(s) dealing with the RPC request(s). This means that only one of the channels of communication to the node's peers will be bloc
OSV
CometBFT PeerState JSON serialization deadlock
osv·2023-07-05
CVE-2023-34450 [MEDIUM] CometBFT PeerState JSON serialization deadlock
CometBFT PeerState JSON serialization deadlock
### Impact
An internal modification to the way struct `PeerState` is serialized to JSON introduced a deadlock when new function MarshallJSON is called. This function can be called from two places:
1. Via logs
* Setting the `consensus` logging module to "debug" level (should not happen in production), and
* Setting the log output format to JSON
2. Via RPC `dump_consensus_state`
Case 1 above, which should not be hit in production, will eventually hit the deadlock in most goroutines, effectively halting the node.
In case 2, only the data structures related to the first peer will be deadlocked, together with the thread(s) dealing with the RPC request(s). This means that only one of the channels of communication to the node's peers will be bloc
No detection rules found.
No public exploits indexed.
No writeups or analysis indexed.
https://github.com/cometbft/cometbft/pull/524https://github.com/cometbft/cometbft/pull/863https://github.com/cometbft/cometbft/pull/865https://github.com/cometbft/cometbft/security/advisories/GHSA-mvj3-qrqh-cjvrhttps://github.com/cometbft/cometbft/pull/524https://github.com/cometbft/cometbft/pull/863https://github.com/cometbft/cometbft/pull/865https://github.com/cometbft/cometbft/security/advisories/GHSA-mvj3-qrqh-cjvr
2023-07-03
Published